This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Use textContent to retrieve text of nodes. #216
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues checking for text within a node, similar to #195. I'm setting the width and height on
html
andbody
to 100% and hiding overflow onbody
. The text was within an absolute positioned container spanning the height of the page. When overflow was set toauto
orhidden
on the container the text would no longer be found.I was unable to recreate the issue even with the full HTML and CSS from my application. To avoid spending all weekend trying to recreate it in a test case I verified the
textContent
change works by removing the line in the original fix and by using it in my application.There are some differences between
innerText
andtextContent
, best explained by MDN:The one difference I can see possibly being an issue is the fact that
textContent
will return the text of hidden elements. There's currently no test for it though, so perhaps it is not an issue.